Skip to content

fix: resolve clashes between syntax-highlighter & auto-closer in the REPL #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

Snehil-Shah
Copy link
Member

Description

What is the purpose of this pull request?

This pull request resolves a bug where the syntax highlighter stops working after entering a closing symbol over an existing closing symbol.

Before:
https://github.com/stdlib-js/stdlib/assets/130062020/2694562b-4e46-47a8-a007-86d9da3236b5

After:
https://github.com/stdlib-js/stdlib/assets/130062020/0e57ada4-a81f-4268-a0e9-96ae6409c421

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@kgryte kgryte added the REPL Issue or pull request specific to the project REPL. label Jun 1, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Snehil-Shah.

@kgryte kgryte merged commit e538d43 into stdlib-js:develop Jun 1, 2024
6 checks passed
aman-095 pushed a commit to aman-095/stdlib that referenced this pull request Jun 13, 2024
PR-URL: stdlib-js#2290
Reviewed-by: Athan Reines <kgryte@gmail.com>
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REPL Issue or pull request specific to the project REPL.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants